Deprecate command line arguments (other than --help) that are not prefixed with --kokkos*
#5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
commented
Jun 16, 2022
| } | ||
| if (check_arg(arg[iarg], "--kokkos-ndevices")) { | ||
| warn_deprecated_command_line_argument("--kokkos-ndevices", | ||
| "--kokkos-num-devices"); | ||
| } | ||
| // Find the number of device (expecting --device=XX) | ||
| if (!((strncmp(arg[iarg], "--kokkos-num-devices=", 21) == 0) || | ||
| (strncmp(arg[iarg], "--num-ndevices=", 14) == 0) || | ||
| (strncmp(arg[iarg], "--num-devices=", 14) == 0) || |
There was a problem hiding this comment.
That was a bug and essentially never worked...
dalg24
changed the title
--help) that are not prefixed by --kokkos*--help) that are not prefixed with --kokkos*
JBludau
reviewed
Jun 16, 2022
| kokkos-tool as command-line arguments. E.g. | ||
| `<EXE> --kokkos-tools-args="-c input.txt"` will | ||
| pass `<EXE> -c input.txt` as argc/argv to tool | ||
|
|
There was a problem hiding this comment.
Would it make sense to also print the env vars we process? I do not know any other program that does this, but might be worth a thought when concerning user friendlyness ... having one place that shows runtime config options
ldh4
approved these changes
Jun 17, 2022
fnrizzi
approved these changes
Jun 17, 2022
JBludau
approved these changes
Jun 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing what was decided at the developer meeting.
Warn when they are used but do not change the behavior.