Drop numa args in threads backend initialization #5127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnrizzi
approved these changes
Jun 21, 2022
ldh4
approved these changes
Jun 21, 2022
Comment on lines
+586
to
+590
| // legacy arguments | ||
| unsigned thread_count = thread_count_arg == -1 ? 0 : thread_count_arg; | ||
| unsigned use_numa_count = 0; | ||
| unsigned use_cores_per_numa = 0; | ||
| bool allow_asynchronous_threadpool = false; |
There was a problem hiding this comment.
Why do you want to keep legacy arguments if they are not exposed anyway?
There was a problem hiding this comment.
See the description on the original PR.
The goal of this PR is not to actually perform the refactoring. What else would you do?
There was a problem hiding this comment.
Do the refactoring. 😉
I just want to make sure we don't forget about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening #5121 that I accidentally closed