Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fill_random with execution space #5181

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Implement fill_random with execution space #5181

merged 1 commit into from
Jul 11, 2022

Conversation

masterleinad
Copy link
Contributor

@kyungjoo-kim requested this on slack. Part of #4792.

@kyungjoo-kim
Copy link
Contributor

thank you.

@masterleinad
Copy link
Contributor Author

OpenMPTarget failing in openmptarget.unique_token_instance looks spurious:

 RUN      ] openmptarget.unique_token_instance
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestUniqueToken.hpp:151: Failure
4: Expected equality of these values:
4:   sum
4:     Which is: 9999990
4:   int64_t(N) * R
4:     Which is: 10000000
4: [  FAILED  ] openmptarget.unique_token_instance (229 ms)

@masterleinad masterleinad marked this pull request as ready for review July 7, 2022 17:54
dalg24
dalg24 reviewed Jul 10, 2022
View reviewed changes
algorithms/unit_tests/TestRandom.hpp

Kokkos::fence();
exec.fence();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't even need a fence here do we?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that the semantic for this particular overload of parallel_reduce?

Regardless, does it hurt anything for the test to have it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that the semantic for this particular overload of parallel_reduce?

Yes

Regardless, does it hurt anything for the test to have it?

Not really

@dalg24 dalg24 merged commit 83f4c51 into kokkos:develop Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller approved these changes

@dalg24 dalg24 dalg24 left review comments

@fnrizzi fnrizzi fnrizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@masterleinad @kyungjoo-kim @PhilMiller @dalg24 @fnrizzi