Preserve KOKKOS_INVALID_INDEX in ViewDimension and ArrayLayout construction

[janciesko]

• Preserves KOKKOS_INVALID_INDEX in ViewDimension and ArrayLayout construction.
• Fixes Nightly Trilinos failure in phalanx unit test (all backends) Phalanx_tViewOfViews_MPI_1: Constructor for Kokkos View mismatched number of arguments #5175
• Adds unit test for View construction from Layout. This would have failed previously (as found in the issue).

[masterleinad]

Doesn't this also need to be the dynamic rank?

[janciesko]

From looking at TestViewLayoutTiled and the layout implementation it looks like we do only support static ranks. I think we should be good with that for now.

[crtrott]

Note, this does change the behavior to what mdspan does. I wouldn't necessarily document that yet, but I think it is the correct thing to do: i.e. you can either pass dynamik_rank or rank arguments to the View. Note the whole layout() thing is still a bit messy. For example this would still allow this I think:

View<int*> a("A",N);
View(int*[4]) b("B",a.layout());

But lets fix that later.

[masterleinad]

I think this is good enough as a fix. We should also check for matching static extents in a follow-up.

[PhilMiller]

I expect this will help with the issues I was trying to address in DynRankView. I'll need to look at the code, and maybe try to update my PRs related to that to be sure. Probably not a reason to hold this up if it addresses the more pressing issue(s) for core View.

[janciesko]

Note, this does change the behavior to what mdspan does. I wouldn't necessarily document that yet, but I think it is the correct thing to do: i.e. you can either pass dynamik_rank or rank arguments to the View. Note the whole layout() thing is still a bit messy. For example this would still allow this I think:

View<int*> a("A",N);
View(int*[4]) b("B",a.layout());

But lets fix that later.

Yes, that's fixable.

[janciesko]

Retest this please

[crtrott]

I wonder whether that timeout is real? I.e. we screw somewhere up and don't get all the information over and a loop nest now is infinite long or so?

[dalg24]

I wonder whether that timeout is real? I.e. we screw somewhere up and don't get all the information over and a loop nest now is infinite long or so?

I've seen this failure (OpenMP timeout) in other PRs