[ready] Fix move backward #5191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unrelated failure |
cz4rs
reviewed
Jul 11, 2022
cz4rs
reviewed
Jul 11, 2022
cz4rs
reviewed
Jul 11, 2022
cz4rs
reviewed
Jul 11, 2022
cz4rs
approved these changes
Jul 11, 2022
|
unrelated failure from OpenMPTarget |
PhilMiller
reviewed
Jul 11, 2022
PhilMiller
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes a bug in how the indexing was done in the impl of
move_backward. It also adds a test as it seems the was not one before (which is strange).