-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename tools settings for consistency #5201
Conversation
tool_help -> tools_help tool_lib -> tools_libs tool_args -> tools_args
5d9f217
to
5b00b60
Compare
|
I would slightly prefer spelling out "libs" -> "libraries". Anyone else on that boat? |
While I don't have any strong opinion on either option, it kinda looks nice to have all tools options be aligned and have the same lengths by leaving "libs" to have the same character count as "args" and "help". |
I kinda like libraries a bit more too. |
If we are going to spell out "libraries", should we also spell out "arguments"? |
My recollection from the dev meeting was we keep the name as they are currently implemented in this PR, that is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me (as well as both libraries and arguments).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My recollection from the dev meeting was we keep the name as they are currently implemented in this PR, that is
kokkos_tools_{help,libs,args}
That's what I recall as well.
As part of our effort to cleanup or initialization settings, this PR is suggesting to make the following changes to the tools options:
InitializationSetting::{set,has,get}_...
: renamedtool_lib -> tools_libs
,tool_args -> tools_args
, andtool_help -> tools_help
--kokkos-tools-{library -> libs}
--kokkos-tools-args
and--kokkos-tools-help
unchanged.KOKKOS_{PROFILE_LIBRARY -> TOOLS_LIBS}
and addedKOKKOS_TOOLS_ARGS
We still look for
KOKKOS_PROFILE_LIBRARY
and raise a warning stating it is deprecated. If bothKOKKOS_PROFILE_LIBRARY
andKOKKOS_TOOLS_LIBS
are set, we ensure that they match.Haven't added
KOKKOS_TOOLS_HELP
. Let me know if you think I should do so.The
Kokkos::Tools::InitArguments
struct is not updated as part of this PR.kokkos/core/src/impl/Kokkos_Profiling.hpp
Lines 64 to 73 in e0347a2
We still need to decide whether we just want to change the data member name or opt for a design similar to what we did in Core. In any case I would prefer to handle it in a follow-up PR.