Assert that layout construction from extents is valid where used #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #5205 |
dalg24
reviewed
Jul 12, 2022
core/src/Kokkos_View.hpp
Outdated
| check_input_args::yes) { | ||
| static_assert(traits::array_layout::is_extent_constructible, | ||
| "Layout is not extent constructible. Use overload taking a " | ||
| "layout object instead.\n"); |
There was a problem hiding this comment.
Suggested change
| "layout object instead.\n"); | |
| "layout object instead."); |
same comment everywhere
dalg24
reviewed
Jul 12, 2022
core/src/Kokkos_View.hpp
Outdated
| check_input_args::yes) {} | ||
| check_input_args::yes) { | ||
| static_assert(traits::array_layout::is_extent_constructible, | ||
| "Layout is not extent constructible. Use overload taking a " |
There was a problem hiding this comment.
Please suggest a message that will be easier to understand for users
There was a problem hiding this comment.
I don't know, seems pretty obvious to me?
There was a problem hiding this comment.
"is not constructible from extent arguments. Use ..."
There was a problem hiding this comment.
I would just use the second sentence "Use the overload taking a layout object instead!".
ajpowelsnl
added
Blocks Promotion
Rombur
approved these changes
Jul 19, 2022
Also introduces a missing layout overload for required_allocation_size
nliber
approved these changes
Jul 19, 2022
This was referenced Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introduces a missing layout overload for required_allocation_size