Refactor parsing of command line arguments and environment variables #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah abort. |
dalg24
force-pushed
the
refactor_int_and_bool_env_var_parsing
branch
from
a3d93d8
to
a0574f4
Compare
nliber
approved these changes
Jul 15, 2022
ldh4
reviewed
Jul 16, 2022
| @@ -176,6 +176,10 @@ unsigned get_process_id() { | |||
| #endif | |||
| } | |||
|
|
|||
| bool is_valid_num_threads(int x) { return x > 0; } | |||
|
|
|||
| bool is_valid_device_id(int x) { return x >= 0; } | |||
There was a problem hiding this comment.
Should there also be a check here against the upper limit of valid device ids?
Improve error message Co-authored-by: Dong Hun Lee <59181952+ldh4@users.noreply.github.com>
ldh4
reviewed
Jul 16, 2022
Co-authored-by: Dong Hun Lee <59181952+ldh4@users.noreply.github.com>
ldh4
approved these changes
Jul 16, 2022
crtrott
approved these changes
Jul 18, 2022
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Jul 22, 2022
Address changes in kokkos/kokkos#5221, also discussed in kokkos/kokkos#5255
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 5, 2022
Address changes in kokkos/kokkos#5221, also discussed in kokkos/kokkos#5255
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 12, 2022
Address changes in kokkos/kokkos#5221, also discussed in kokkos/kokkos#5255
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 30, 2022
Address changes in kokkos/kokkos#5221, also discussed in kokkos/kokkos#5255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case insensitive
(1,yes,true)->truecase insensitive
(0,no,false)->falseotherwise call
Kokkos::abort()--kokkos-disable-warnings=falsewould yielddisable_warnings=trueand now actually meansfalseKOKKOS_DISABLE_WARNINGS=ONwould yielddisable_warnings=truebut now is not recognized and causes abnormal termination of the program--kokkos-num-devices=3 --num-devices=4would yieldnum_devices=3and now givenum_devices=4