-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also filter out -pedantic-errors
from nvcc options
#5235
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to target the develop
branch with your pull request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than targeting the wrong branch, this looks OK to me.
Same as what Daniel, said, if you can retarget this on develop, we will approve. |
Urgh, let me rebase, sorry |
See lammps/lammps#3353 and jbeder/yaml-cpp#831 for some context.
OK to test |
Thanks for the contribution. |
See lammps/lammps#3353 and jbeder/yaml-cpp#831 for some context.