Add is_finalized #5247
Merged
Add is_finalized #5247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_finalized is also checked in the ScopeGuard constructor Co-Authored-By: Damien L-G <dalg24@gmail.com>
dalg24
reviewed
Jul 20, 2022
dalg24
approved these changes
Jul 20, 2022
|
Cuda timing based test failing in one of the CUDA builds |
masterleinad
approved these changes
Jul 21, 2022
dalg24
requested changes
Jul 21, 2022
dalg24
approved these changes
Jul 21, 2022
|
Failure (machine running out of space) are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5208.
is_finalized is also checked in the ScopeGuard constructor
Co-Authored-By: Damien L-G dalg24@gmail.com