-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn users when a flag prefixed with -[-]kokkos
is not recognized and do not remove it
#5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
added
the
Enhancement
Improve existing capability; will potentially require voting
label
Jul 22, 2022
PS: feel free to suggest a better name for the function |
dalg24
commented
Jul 25, 2022
lucbv
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fine, I like the use of regex
JBludau
approved these changes
Jul 25, 2022
dalg24
changed the title
Warn users when a flag prefixed with
Warn users when a flag prefixed with Jul 25, 2022
-[-]kokkos
is not recognized-[-]kokkos
is not recognized and do not remove it
dalg24
force-pushed
the
warn_not_recognized_cla
branch
from
July 25, 2022 23:50
109388a
to
f2221d2
Compare
Retest this please |
PhilMiller
reviewed
Jul 26, 2022
if (check_arg(argv[iarg], "--kokkos-numa") || | ||
check_arg(argv[iarg], "--numa")) { | ||
warn_deprecated_command_line_argument(get_flag(argv[iarg])); | ||
// remove flag if prefixed with '--kokkos-' | ||
remove_flag = std::string(argv[iarg]).find("--kokkos-") == 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
remove_flag = std::string(argv[iarg]).find("--kokkos-") == 0; | |
bool begins_with_kokkos = std::string(argv[iarg]).find("--kokkos-") == 0; // move up to top | |
remove_flag = begins_with_kokkos; |
PhilMiller
approved these changes
Jul 26, 2022
crtrott
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--kokkos
or-kokkos
Impl::do_not_warn_not_recognized_command_line_argument
. By default, we only exclude those starting with--kokkos-tool
but we could expand later as needed.--kokkos
that were not actually handled