Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYCL: require GPU is GPU architecture is set #5264

Merged
merged 1 commit into from
Jul 25, 2022
Merged

SYCL: require GPU is GPU architecture is set #5264

merged 1 commit into from
Jul 25, 2022

Conversation

masterleinad
Copy link
Contributor

Fixes #5254.

dalg24
dalg24 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thought on introducing some KOKKOS_ARCH_NVIDIA_GPU and KOKKOS_ARCH_AMD_GPU macros?

@masterleinad
Copy link
Contributor Author

Any thought on introducing some KOKKOS_ARCH_NVIDIA_GPU and KOKKOS_ARCH_AMD_GPU macros?

I thought about it but couldn't really make up my mind about it. In the end, checking for any GPU architecture is just used in two places (including this pull request) within the SYCL backend implementation.

@crtrott crtrott merged commit abdc8c5 into kokkos:develop Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masterleinad @dalg24 @crtrott