Do not forget to set last element to nullptr when removing a flag in Kokkos::initialize
#5272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nliber
approved these changes
Jul 27, 2022
|
This needs to be picked to 3.7 also, right? |
I would like it to be considered for 3.7 yes |
masterleinad
approved these changes
Jul 27, 2022
|
Just issue a PR against release-candidate too |
dalg24
added a commit
that referenced
this pull request
Jul 27, 2022
Cherry pick fixup command line arguments handling (#5272) into RC 3.7
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Aug 30, 2022
Updates for passing flags to Kokkos::initialize when kokkos deprecated code is disabled. See kokkos/kokkos#5272 for reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted when working on the documentation for
Kokkos::initializeAlso now raising warning in kokkos-tools when flags are not recognized