Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5274 DynamicView: Properly resize mirror instances after construction #5276

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

PhilMiller
Copy link
Contributor

Cherry-pick of #5275 for the 3.7 release branch

@PhilMiller PhilMiller requested a review from crtrott July 27, 2022 01:39
@PhilMiller
Copy link
Contributor Author

As best I can tell, the one CI failure was an OpenACC test failing to find a GPU on startup. Clearly unrelated to this.

@PhilMiller PhilMiller added the Blocks Promotion Overview issue for release-blocking bugs label Jul 27, 2022
@PhilMiller
Copy link
Contributor Author

'Blocks Promotion' added to make sure this doesn't get forgotten - if you decide to remove it, I'll be disappointed, but not upset

Copy link
Contributor

@janciesko janciesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhilMiller PhilMiller moved this from In Review to Done, pending release in Developer: Phil Miller Jul 27, 2022
@dalg24 dalg24 merged commit 5003900 into kokkos:release-candidate-3.7.00 Jul 28, 2022
@PhilMiller PhilMiller deleted the 3.7-5274 branch July 28, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks Promotion Overview issue for release-blocking bugs
Projects
Developer: Phil Miller
Done in Release 3.7
Development

Successfully merging this pull request may close these issues.

None yet

4 participants