-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support finding libquadmath with native compiler support #5286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply my suggestion
Looks good other than that
This seems like a good candidate for 3.7 |
fa8c537
to
e429343
Compare
They are not unrelated but make sure the detection also works with |
I think this is not a bug fix so I would abstain from pulling more stuff in. |
I was looking at it as something that would ease our support burden from users who have trouble with this aspect of the build/installation process |
There are a bunch of CI failures (mostly timing based but OpenMPTarget can't find LIBDL???) but this pull request only affects the
|
e429343
to
613f100
Compare
GET_TARGET_PROPERTY(TPL_ORIGINAL_NAME ${TPL_IMPORTED_NAME} ALIASED_TARGET) | ||
IF (NOT TPL_ORIGINAL_NAME) | ||
SET(TPL_ORIGINAL_NAME ${TPL_IMPORTED_NAME}) | ||
ENDIF() | ||
KOKKOS_EXPORT_IMPORTED_TPL(${TPL_ORIGINAL_NAME}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Make sure this is in the description of the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment. Without this, we are getting
-- Performing Test KOKKOS_QUADMATH_COMPILER_SUPPORT
-- Performing Test KOKKOS_QUADMATH_COMPILER_SUPPORT - Success
CMake Error at cmake/kokkos_functions.cmake:187 (INSTALL):
INSTALL TARGETS given target "Kokkos::LIBQUADMATH" which is an alias.
Call Stack (most recent call first):
cmake/kokkos_functions.cmake:288 (KOKKOS_EXPORT_IMPORTED_TPL)
cmake/kokkos_tpls.cmake:86 (KOKKOS_IMPORT_TPL)
cmake/kokkos_tribits.cmake:247 (INCLUDE)
CMakeLists.txt:188 (KOKKOS_SETUP_BUILD_ENVIRONMENT)
gcc
oftentimes bundleslibquadmath
and doesn't need any extra libraries or include directories (which would not be contained inCMake
's search paths anyway).Hence, try if the compiler supports
libquadmath
natively first before doing the standard package search.KOKKOS_IMPORT_TPL
needed a workaround to be able to create a consistent target whetherKOKKOS_QUADMATH_COMPILER_SUPPORT
is true or not.This should in particular help with testing
libquadmath
support.