Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all deprecations in Kokkos 3 #5297

Merged
merged 12 commits into from
Aug 11, 2022
Merged

Remove all deprecations in Kokkos 3 #5297

merged 12 commits into from
Aug 11, 2022

Conversation

masterleinad
Copy link
Contributor

  • Keeps partiton_master deprecated.
  • Introduces Kokkos_ENABLE_DISABLED_CODE_4.

dalg24
dalg24 reviewed Jul 29, 2022
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the public header changes in a separate PR or at the very least in a separate commit

@masterleinad masterleinad marked this pull request as ready for review July 30, 2022 20:46
dalg24
dalg24 reviewed Aug 9, 2022
View reviewed changes
core/src/Kokkos_Core_fwd.hpp Outdated
Comment on lines 101 to 103
#ifdef KOKKOS_ENABLE_DEPRECATED_CODE_3
struct InitArguments;
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's buy people more time on that one

dalg24
dalg24 reviewed Aug 9, 2022
View reviewed changes
core/src/Kokkos_MathematicalFunctions.hpp Outdated
@@ -105,16 +105,6 @@ using promote_2_t = typename promote_2<T, U>::type;
#endif
#endif

#if defined(KOKKOS_ENABLE_DEPRECATED_CODE_3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the math functions too we should allow for more time to transition

@masterleinad
Copy link
Contributor Author

Relevant changes in this pull request:

  • remove pthread support (except for the trilinos mapping)
  • including private headers is an error
  • remove deprecations in conatainers/src/Kokkos_Functional.hpp (first_argument etc.)
  • remove deprecated OffsetView constructor
  • remove deprecated behavior of UnorderedMap::value_at/key_at
  • remove CudaSpace::access_error, CudaUVMSpace::number_of_allocations, CUDA_SAFE_CALL
  • remove TeamPolicy::vector_length
  • remove HIPSpace::access_error, HIP_SAFE_CALL
  • remove Kokkos::Experimental:Iterate/Rank/MDRangePolicy aliases
  • remove Impl::is_array_layout/is_execution_policy/is_execution_space/is_memory_space/is_memory_traits
  • remove Kokkos::is_space::host_memory_space/host_execution_space/host_mirror_space, Kokkos::Impl::is_space, Kokkos::Impl::SpaceAccessibility
  • remove create_mirror_view(space,view,WithoutInitializing)
  • remove finalize_all
  • ScopeGuard warnings are errors
  • partition_master -> DEPRECATED_CODE_4, remove partition(...), create_instance
  • remove ActiveExecutionMemorySpace, MemorySpaceAccess, verify_space
  • remove KOKKOS_CONSTEXPR_14, KOKKOS_DEPRECATED_TRAILING_ATTRIBUTE, KOKKOS_THREAD_LOCAL
  • algorithm/math functions in Experimental namespace -> DEPRECATED_CODE_4
  • remove parallel_* with string last.
  • remove Kokkos::is_reducer_type, array reductions with a raw pointer
  • remove ProfilingSection::getName/getSectionID`
  • remove Kokkos::Impl::is_view
  • error out on non-empty WorkTag.
  • initArguments -> DEPRECATED_CODE_4
  • remove impl/Kokkos_Timer.hpp

Consider reintroducing DEPRECATED_CODE_3 and use it for the code not removed above but moved to DEPRECATED_CODE_4

dalg24
dalg24 approved these changes Aug 11, 2022
View reviewed changes
cmake/compile_tests/pthread.cpp
@@ -1,14 +0,0 @@
#include <pthread.h>

void* kokkos_test(void* args) { return args; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oversight forgot to remove that file in 9147621

@dalg24 dalg24 merged commit 441f39f into kokkos:develop Aug 11, 2022
@masterleinad masterleinad mentioned this pull request Aug 16, 2022
Merged
@masterleinad masterleinad mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldh4 ldh4 ldh4 left review comments

@dalg24 dalg24 dalg24 approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@masterleinad @dalg24 @crtrott @ldh4