Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop reciprocal_overflow_threshold from the numeric traits #5326

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Drop reciprocal_overflow_threshold from the numeric traits #5326

merged 1 commit into from
Aug 11, 2022

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Aug 11, 2022 •
edited

LEWG voted its removal when reviewing P2551R0 on 2022/03/29

I propose simple removal (not going through deprecation).

@dalg24
Drop reciprocal_overflow_threshold trait
8f73a3c 
LEWG voted its removal when reviewing P2551R0 on 2022/03/29
@dalg24 dalg24 mentioned this pull request Aug 11, 2022
Merged
@dalg24
Copy link
Member Author

dalg24 commented Aug 11, 2022

Note another of these host_shared_ptr_tracking failure (clearly unrelated but noteworthy)

[ RUN      ] hpx.host_shared_ptr_tracking
/home/runner/work/kokkos/kokkos/kokkos/core/unit_test/TestHostSharedPtrAccessOnDevice.hpp:208: Failure
Expected equality of these values:
  2
  f1.use_count()
    Which is: 3
[  FAILED  ] hpx.host_shared_ptr_tracking (0 ms)

JBludau
JBludau approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dalg24 dalg24 merged commit 839df99 into kokkos:develop Aug 11, 2022
@dalg24 dalg24 deleted the drop_reciprocal_overflow_thresold_trait branch August 11, 2022 19:41
@dalg24 dalg24 mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crtrott crtrott crtrott approved these changes

@JBludau JBludau JBludau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dalg24 @crtrott @JBludau