Add overloads of hypot math function that take 3 arguments
#5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It turns out neither CUDA, HIP, nor SYCL provide the three-argument version of |
Rombur
approved these changes
Aug 17, 2022
| } \ | ||
| inline bool FUNC(long double x) { \ | ||
| inline long double FUNC(long double x, long double y, long double z) { \ | ||
| using std::FUNC; \ |
There was a problem hiding this comment.
Why don't you use KOKKOS_IMPL_MATH_FUNCTIONS_NAMESPACE here?
There was a problem hiding this comment.
For long double on the host-side we use the math functions from the standard library
crtrott
approved these changes
Aug 17, 2022
|
Considering the queue in the CI I will not rerun |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested on Slack
See #4767
Drive by changes more C++17