Move HIP out of Experimental #5383
Conversation
| namespace Experimental { | ||
| class SYCL; | ||
| class HIP; |
There was a problem hiding this comment.
This code is not invalid. The compiler compiles that Experimental::HIP is already defined. I don't think that many users will hit that problem and the fix in user code is pretty simple.
There was a problem hiding this comment.
not -> now
In other words, this PR would break code that had forward declarations of HIP or HIPSpace in Kokkos::Experimental namespace.
|
Retest this please |
There was a problem hiding this comment.
looks good.
The only two things I found that still use Experimental::HIP are in:
./core/unit_test/TestAbort.hpp:123: if (std::is_same<ExecutionSpace, Kokkos::Experimental::HIP>::value) {
./core/unit_test/TestViewMemoryAccessViolation.hpp:202: if (std::is_same<ExecutionSpace, Kokkos::Experimental::HIP>::value) {
| std::string("duplicated_") + original_view.label(), | ||
| exec_space), | ||
| arg_N[0], arg_N[1], arg_N[2], arg_N[3], arg_N[4], arg_N[5], arg_N[6], | ||
| arg_N[7]); |
There was a problem hiding this comment.
I used the wrong version of clang-format. Will fix it.
Rombur
force-pushed
the
hip_experimental
branch
from
c55b634
to
0fedb0a
Compare
Rombur
force-pushed
the
hip_experimental
branch
from
0fedb0a
to
39d0d58
Compare
Move the execution and memory spaces associated with HIP outside of experimental. I have added an alias in
core/src/Kokkos_HIP.hppso that current codes still work. The old code is not deprecated, I wasn't sure what was the plan.