#5385 Add necessary fence() calls in sorting routines that were missing them #5389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is based on #5388, so that should be merged first |
…than BinSort constructors
PhilMiller
force-pushed
the
5385-develop-sort-fence
branch
from
a8f24f8
to
4689208
Compare
|
The preceding PR was merged, so this is good to review now. |
Rombur
reviewed
Aug 31, 2022
| typename ViewType::execution_space exec; | ||
| sort(exec, view); | ||
| exec.fence("Kokkos::Sort: fence after sorting"); | ||
| exec.fence("Kokkos::sort: fence after sorting"); |
There was a problem hiding this comment.
Suggested change
| exec.fence("Kokkos::sort: fence after sorting"); | |
| exec.fence("Kokkos::sort: after"); |
Rombur
reviewed
Aug 31, 2022
| @@ -638,6 +649,7 @@ std::enable_if_t<Kokkos::is_execution_space<ExecutionSpace>::value> sort( | |||
|
|
|||
| template <class ViewType> | |||
| void sort(ViewType view, size_t const begin, size_t const end) { | |||
| Kokkos::fence("Kokkos::sort: before"); | |||
| typename ViewType::execution_space exec; | |||
| sort(exec, view, begin, end); | |||
| exec.fence("Kokkos::Sort: fence after sorting"); | |||
There was a problem hiding this comment.
Suggested change
| exec.fence("Kokkos::Sort: fence after sorting"); | |
| exec.fence("Kokkos::sort: after"); |
Rombur
approved these changes
Aug 31, 2022
crtrott
approved these changes
Aug 31, 2022
This was referenced Oct 12, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting routines that don't take an execution space parameter need to globally fence before calling any kernels on a default-constructed execution space instance, to ensure that input data is stable.
Fixes #5385