#4077 Follow-on cleanup: drop volatile-qualified members from Pair and Complex

[PhilMiller]

Inspired by documentation work in kokkos/kokkos-core-wiki#151, whose corresponding PR will reflect this

[dalg24]

Please guard it with DEPRECATED_CODE_4

[PhilMiller]

Please guard it with DEPRECATED_CODE_4

I expect they're probably unused.

Could we go with 3, and see if anyone complains once 4.0 ships, so we can drop them in 4.1? I know we're technically late, but it may be immaterial.

[dalg24]

Please guard it with DEPRECATED_CODE_4

I expect they're probably unused.

Could we go with 3, and see if anyone complains once 4.0 ships, so we can drop them in 4.1? I know we're technically late, but it may be immaterial.

I would be fine with 4. I think Christian was leaning towards 3. @crtrott please advise.

[PhilMiller]

Following comments from @dalg24 I concluded the following

I’m considering the possibility of code that was written to work with 3.6, and then later adapted to also compile without warnings or deprecation errors on 3.7/4.0 - i.e. It defines some custom join or operator+= for both volatile qualified arguments, and non-qualified arguments. At present, the code will compile without warnings against 3.7/develop, and use the non-qualified overloads. If the overloads in that PR are made unavailable, then the old disused volatile qualified overloads will now fail to compile, because the operators they might call will be missing. So, that leads me to agree to mark it 4 and not 3.

I will amend and rebase

[masterleinad]

Should we deprecate them properly with KOKKOS_DEPRECATED?

[PhilMiller]

Should we deprecate them properly with KOKKOS_DEPRECATED?

... Yes

[dalg24]

I find it interesting that it works in the NVHPC build and not in the OPENACC one.
They use nvc++ version 22.7 and 22.3 respectively.
Let's check if it works with more recent version of the compiler and bump the version if that happens to do the trick
@seyonglee @pedrovalerolara

[dalg24]

Nevermind I see the same issue with 22.9
We need to report this.

[dalg24]

#5604 fixes the issue