Add Kokkos::fma(x, y, z) math function (fused multiply-add) #5428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for consistency with providing the same functions as <cmath> in namespace Kokkos, and important to ensure that eventual users of SIMD can use Kokkos::fma in templated code and get SIMD FMA instructions when expected
dalg24
requested changes
Sep 6, 2022
crtrott
reviewed
Sep 6, 2022
| @@ -424,7 +424,7 @@ DEFINE_BINARY_FUNCTION_EVAL(copysign, 1); | |||
| template <typename T, typename U, typename V> \ | |||
| static KOKKOS_FUNCTION auto eval(T x, U y, V z) { \ | |||
| static_assert( \ | |||
| std::is_same<decltype(Kokkos::FUNC((T)0, (U)0), (V)0), \ | |||
| std::is_same<decltype(Kokkos::FUNC((T)0, (U)0, (V)0)), \ | |||
There was a problem hiding this comment.
The good old comma operator...
There was a problem hiding this comment.
Was going through the 2-arg version... Thanks for fixing
dalg24
approved these changes
Sep 7, 2022
|
Adding reference to #4767 |
|
HIP failure on the new machine that I was setting up yesterday is clearly unrelated |
dalg24
changed the title
dalg24
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for consistency with providing
the same functions as in
namespace Kokkos, and important to
ensure that eventual users of SIMD
can use Kokkos::fma in templated code
and get SIMD FMA instructions when
expected