Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Desul atomics to support compiling CUDA with nvc++ #5431

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Refactor Desul atomics to support compiling CUDA with nvc++ #5431

merged 4 commits into from
Sep 23, 2022

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Sep 6, 2022

Not asking for feedback at this time

@dalg24
Copy link
Member Author

dalg24 commented Sep 8, 2022

Retest this please

2 similar comments
@dalg24
Copy link
Member Author

dalg24 commented Sep 9, 2022

Retest this please

@dalg24
Copy link
Member Author

dalg24 commented Sep 9, 2022

Retest this please

@dalg24 dalg24 mentioned this pull request Sep 13, 2022
Merged
@dalg24 dalg24 marked this pull request as ready for review September 22, 2022 19:53
@dalg24
Copy link
Member Author

dalg24 commented Sep 22, 2022

This is ready

@masterleinad
Copy link
Contributor

Did you do a plain copy from desul?

@dalg24 dalg24 force-pushed the nvcc-support-with-desul branch 2 times, most recently from 2a0e8da to b6f21d5 Compare September 23, 2022 12:00
@dalg24
Copy link
Member Author

dalg24 commented Sep 23, 2022 •
edited

Loving that case insensitive filesystem desul/atomics/Lock_Array_{Cuda -> CUDA}.hpp

@dalg24
Copy link
Member Author

dalg24 commented Sep 23, 2022

I withdrew the change to the CI. Will tackle that in a follow up PR.

@dalg24
Copy link
Member Author

dalg24 commented Sep 23, 2022 •
edited

Did you do a plain copy from desul?

I cleaned up history

@crtrott crtrott merged commit b152efa into kokkos:develop Sep 23, 2022
@dalg24 dalg24 mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rombur Rombur Rombur approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dalg24 @masterleinad @Rombur @crtrott