Promote math constants Kokkos::{Experimental -> numbers} and add missing variables without the _v suffix
#5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use mathematical functions from Kokkos::numbers namespace * Prefer variable template helpers from the numerical traits
dalg24
changed the title
Kokkos::{Experimental -> numbers} and add missing variables with the _v suffixKokkos::{Experimental -> numbers} and add missing variables without the _v suffix
dalg24
force-pushed
the
promote_math_constants
branch
from
32b234d
to
fe6c769
Compare
Rombur
approved these changes
Sep 7, 2022
ldh4
reviewed
Sep 7, 2022
|
Lets discuss the namespace question today in the meeting. |
ldh4
approved these changes
Sep 7, 2022
|
HIP failure was my rebooting the new machine |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational: There is no good reason to keep them in
Kokkos::Experimental::since it is just a backport of the C++20 facility. I opted for theKokkos::numbersnamespace for consistency with the C++ standard. Let me know if you want to capitalize the "N".Drive-by changes:
_vsuffix