Try removing volatile from AtomicDataElement #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
commented
Sep 13, 2022
Comment on lines
+225
to
+226
| operator value_type() const { | ||
| return Kokkos::Impl::atomic_load(ptr, Kokkos::Impl::memory_order_relaxed); |
There was a problem hiding this comment.
This and operator= might be the only significant changes.
|
Is that UniqueToken failure in OpenMPTarget a thing which occasionally goes wrong because of a pre-existing bug, or is there something real there changing due to this PR? |
We have seen that failing before. That test doesn't even use |
crtrott
approved these changes
Sep 26, 2022
|
I think this is good. |
PhilMiller
approved these changes
Sep 26, 2022
|
Ignoring the OpenMPTarget failure |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last hackathon I was mentoring, my team wanted to use
MemorytTraits:::Atomicwith a custom type. This currently requires defining all kinds ofvolatilequalified member functions which is not very user-friendly.It appears that none of the
volatileoverloads inAtomicDataElementare used anymore, though, and there doesn't seem to be a point in combingvolatilewithatomic.Also,
Kokkos_Atomic_is_only_allowed_with_32bit_and_64bit_scalarsis not used at all.