Make sure we don't add '-cuda' to the link line with NVC++ when CUDA is not enabled #5485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Obviously, in an ideal world we don't process that entire block when the CUDA backend is not enabled. Wrapping it in a big if(KOKKOS_ENABLE_CUDA) makes the code less readable and I don't want to get into refactoring the whole thing. I considered introducing a KOKKOS_CUDA_LINK_OPTIONS variables but that would force us to duplicate some target_link_options workaround for CMake version less than 3.18
dalg24
force-pushed
the
nvc++_wo_cuda
branch
from
8f66788
to
584af83
Compare
|
(removed trailing white space) |
|
Performance test failing on |
JBludau
approved these changes
Sep 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5483
Obviously, in an ideal world we don't process that entire block when the CUDA backend is not enabled. Wrapping it in a big
if(KOKKOS_ENABLE_CUDA)makes the code less readable and I don't want to get into refactoring the whole thing. I considered introducing aKOKKOS_CUDA_LINK_OPTIONSvariables but that would force us to duplicate some target_link_options workaround for CMake version less than 3.18