[3.7.1]: Fix memory spaces in create_mirror_view overloads using view_alloc #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okkos#5488) * Fix memory spaces in create_mirror_view overloads using view_alloc * Fixes * Add test * Fix MSVC * Test for host mirrors differently * Use different syntax to fix MSVC * typename -> class * Split Kokkos_CopyViews.hpp * Add separate test to check memory_spaces * Revert "Split Kokkos_CopyViews.hpp" This reverts commit b6643ef. * Fix execution spaces * Improve DynamicView FIXME * Reduce boilerplate in test * Rework tests * Make the tests compile-time only * Fix typos * Rework tests
|
Retest this please. |
|
@masterleinad can you retarget that to the 3.7.01 release candidate? |
masterleinad
changed the base branch from
release-candidate-3.7.00
to
release-candidate-3.7.01
Closed
crtrott
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking #5488.
I decided to hide
if constexprbehind#ifndef KOKKOS_ENABLE_CXX14and adaptedstd::is_same_vand made surestatic constexpris called with two arguments.