Export the flags in KOKKOS_AMDGPU_OPTIONS when using Trilinos #5528
Conversation
| @@ -228,6 +229,9 @@ IF (KOKKOS_HAS_TRILINOS) | |||
| # we have to match the annoying behavior, also we have to preserve quotes | |||
| # which needs another workaround. | |||
| SET(KOKKOS_COMPILE_OPTIONS_TMP) | |||
| IF (KOKKOS_ENABLE_HIP) | |||
| LIST(APPEND KOKKOS_COMPILE_OPTIONS ${KOKKOS_AMDGPU_OPTIONS}) | |||
There was a problem hiding this comment.
Can you confirm that is the right thing to do
CUDA seems to be using KOKKOS_ALL_COMPILE_OPTIONS
Line 246 in 1a63570
There was a problem hiding this comment.
Yes, I know that CUDA does it differently but the current PR is correct for hip
There was a problem hiding this comment.
I think this has something to do with whether its ; separated list or not or so?
There was a problem hiding this comment.
I am asking because I saw
Should we comment then to make sure it does not look like a mistake?
There was a problem hiding this comment.
KOKKOS_COMPILER_OPTIONS is appended to KOKKOS_ALL_COMPILE_OPTIONS just a few lines below.
There was a problem hiding this comment.
OK I see
Line 244 in 1a63570
I don't even want to look why we would need both
KOKKOS_ALL_COMPILE_OPTIONS and KOKKOS_COMPILER_OPTIONS
It does not work. I also though it would be cleaner but then I would need to rewrite more of the build system which I don't want to do. |
With this PR, we export the flags stored in
KOKKOS_AMDGPU_OPTIONSwhen using Trilinos.Related to #5505