Only link against libatomic in gnu-make OpenMPTarget build #5537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors the CMake logic
|
Mirrors logic here: kokkos/core/src/CMakeLists.txt Lines 169 to 171 in d5fcc32 Fixes #5501 |
dalg24
reviewed
Oct 8, 2022
| @@ -491,6 +487,7 @@ ifeq ($(KOKKOS_INTERNAL_USE_SYCL), 1) | |||
| endif | |||
|
|
|||
| ifeq ($(KOKKOS_INTERNAL_USE_OPENMPTARGET), 1) | |||
| KOKKOS_LIBS += -latomic | |||
There was a problem hiding this comment.
Please confirm that we don't want to guard for KOKKOS_INTERNAL_ENABLE_DESUL_ATOMICS equal to 1
There was a problem hiding this comment.
Yeah, I am considering getting rid of that option anyway.
dalg24
approved these changes
Oct 8, 2022
JBludau
approved these changes
Oct 10, 2022
masterleinad
approved these changes
Oct 10, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the CMake logic