[3.7.01] Fix repeated team_reduce without barrier #5552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* __synthreads after cuda_inter_warp_reduction * Add test for repeated team reductions without barrier * Add the same fix for HIP for good measure * Address comments from code review * Add comment * Comment on necessity to use trigonometric functions
Closed
PhilMiller
reviewed
Oct 13, 2022
masterleinad
force-pushed
the
cherry_pick_5540_3.7.1
branch
from
6d894ce
to
19ef3db
Compare
PhilMiller
approved these changes
Oct 13, 2022
crtrott
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking #5540.
Fixes #5475