[3.7.01]: Allow as_view_of_rank_n() to be overloaded for "special" scalar types #5553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as_view_of_rank_n() needs to be overloaded for special scalar types like Sacado that need to pass a hidden dimension. This change adds the necessary SFINAE stuff to allow that to happen. This will require adding the new overload in Trilinos/Sacado. For Trilinos issue #11018 causing runtime failures in Albany.
Closed
masterleinad
force-pushed
the
cherry_pick_5491_3.7.1
branch
from
90174ea
to
08e9810
Compare
|
Jenkins failures are an irrelevant OpenACC failure, and a lack of disk space on OpenMPTarget. They can be ignored. |
PhilMiller
approved these changes
Oct 13, 2022
crtrott
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking #5491.