-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add architecture flags for MSVC #5673
Conversation
cmake/kokkos_arch.cmake
Outdated
@@ -239,6 +239,7 @@ IF (KOKKOS_ARCH_ARMV80) | |||
COMPILER_SPECIFIC_FLAGS( | |||
COMPILER_ID KOKKOS_CXX_HOST_COMPILER_ID | |||
Cray NO-VALUE-SPECIFIED | |||
MSVC NO-VALUE-SPECIFIED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSVC NO-VALUE-SPECIFIED | |
MSVC /arch:armv8.0 |
cmake/kokkos_arch.cmake
Outdated
@@ -248,6 +249,7 @@ IF (KOKKOS_ARCH_ARMV81) | |||
COMPILER_SPECIFIC_FLAGS( | |||
COMPILER_ID KOKKOS_CXX_HOST_COMPILER_ID | |||
Cray NO-VALUE-SPECIFIED | |||
MSVC NO-VALUE-SPECIFIED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSVC NO-VALUE-SPECIFIED | |
MSVC /arch:armv8.1 |
Co-authored-by: Damien L-G <dalg24@gmail.com>
Failures are unrelated (machine out of disk space) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure you update the changelog
Fixes #5663. Note that I haven't tested this myself either.