Update nvcc_wrapper default arch to work with CUDA 12 #5691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the description and explain why we need to change and why 70 is the right compute capability to chose as new default. |
crtrott
added
Blocks Promotion
Closed
Yeah I thought about just getting rid of it, but then I remembered that there were quite a few people who modify the script to set their arch instead of providing the -arch flag properly ... |
fnrizzi
reviewed
Dec 15, 2022
crtrott
force-pushed
the
update_nvcc_wrapper_default_arch
branch
from
57191bd
to
87a6deb
Compare
fnrizzi
approved these changes
Dec 15, 2022
PhilMiller
approved these changes
Dec 15, 2022
|
Test failures are irrelevant things in HIP and OpenMPTarger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our cmake config uses nvcc_wrapper at some point without architecture flag, and thus the default architecture is used. CUDA 12 dropped support for Kepler so 3.5 will not be accepted. arch_70 is supported by CUDA 9 onward, and is unlikely to be dropped anytime soon from CUDA.