Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7.02] Fixes Scratch allocation alignment issues #5692

Merged
merged 5 commits into from
Apr 20, 2023
Merged

[3.7.02] Fixes Scratch allocation alignment issues #5692

merged 5 commits into from
Apr 20, 2023

Conversation

crtrott
Copy link
Member

@crtrott crtrott commented Dec 15, 2022 •
edited by PhilMiller

Cherry pick of #5687 with C++14 compatibility.

Fixes #4942

@PhilMiller PhilMiller added CHANGELOG Item to be included in release CHANGELOG Patch Release labels Dec 15, 2022
@PhilMiller PhilMiller linked an issue Dec 15, 2022 that may be closed by this pull request
Cuda backend fails to allocate a single integer in the PerTeam scratch space. #4942
Closed
dalg24
dalg24 requested changes Dec 16, 2022
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original PR hasn't been merged yet

@PhilMiller PhilMiller added this to the Release 3.7.02 milestone Jan 25, 2023
@masterleinad masterleinad mentioned this pull request Mar 15, 2023
Closed
@crtrott
Copy link
Member Author

crtrott commented Mar 30, 2023

Retest this please.

@Rombur
Copy link
Member

Rombur commented Mar 31, 2023

Retest this please

@masterleinad
Copy link
Contributor

Retest this please.

@crtrott
Copy link
Member Author

crtrott commented Apr 20, 2023

We are merging now and do manual testing

@crtrott crtrott merged commit a3d4fee into kokkos:release-candidate-3.7.02 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 requested changes

@PhilMiller PhilMiller PhilMiller approved these changes

@fnrizzi fnrizzi fnrizzi approved these changes

Assignees
No one assigned
Labels
CHANGELOG Item to be included in release CHANGELOG Patch Release
Projects
None yet
Milestone
Release 3.7.02
Development

Successfully merging this pull request may close these issues.

Cuda backend fails to allocate a single integer in the PerTeam scratch space.
6 participants
@crtrott @Rombur @masterleinad @PhilMiller @dalg24 @fnrizzi