Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7.02] Set the correct device/context in InterOp tests #5701

Merged
merged 1 commit into from
Feb 2, 2023
Merged

[3.7.02] Set the correct device/context in InterOp tests #5701

merged 1 commit into from
Feb 2, 2023

Conversation

masterleinad
Copy link
Contributor

Cherry-picking #5634.

ndellingwood
ndellingwood previously approved these changes Dec 16, 2022
View reviewed changes
@dalg24
Copy link
Member

dalg24 commented Feb 1, 2023

Ignoring NVHPC toolchain issues

dalg24
dalg24 requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is against master...
Please target the 3.7.2 RC branch

@masterleinad masterleinad changed the base branch from master to release-candidate-3.7.02 February 1, 2023 23:31
@masterleinad masterleinad dismissed ndellingwood’s stale review February 1, 2023 23:31

The base branch was changed.

@dalg24
Copy link
Member

dalg24 commented Feb 2, 2023

Same NVHPC failures + one timing-based CUDA build. Ignoring.

@dalg24 dalg24 merged commit 52033ce into kokkos:release-candidate-3.7.02 Feb 2, 2023
@masterleinad masterleinad mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndellingwood ndellingwood ndellingwood left review comments

@dalg24 dalg24 Awaiting requested review from dalg24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masterleinad @dalg24 @ndellingwood