Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7.02] Dont install std algorithm headers multiple times (#5670) #5711

Merged
merged 1 commit into from
Dec 20, 2022
Merged

[3.7.02] Dont install std algorithm headers multiple times (#5670) #5711

merged 1 commit into from
Dec 20, 2022

Conversation

ndellingwood
Copy link
Contributor

  • add ability to provide NOINSTALLHEADERS to kokkos tribits wrapper

  • don't install std algorithm headers twice

  • cmake: remove parse_arguments from KOKKOS_ADD_INTERFACE_LIBRARY

(cherry picked from commit 8303668)

@nmm0 @ndellingwood
kokkos#5667: dont install std algorithm headers multiple times (kokko…
8af83ef 
…s#5670)

* add ability to provide NOINSTALLHEADERS to kokkos tribits wrapper

* don't install std algorithm headers twice

* cmake: remove parse_arguments from KOKKOS_ADD_INTERFACE_LIBRARY

(cherry picked from commit 8303668)
@ndellingwood ndellingwood mentioned this pull request Dec 19, 2022
Merged
cz4rs
cz4rs approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dalg24 dalg24 merged commit 6894f92 into kokkos:release-candidate-3.7.02 Dec 20, 2022
@ndellingwood ndellingwood deleted the cherry-pick-5670-to-3.7.02 branch December 22, 2022 18:35
@PhilMiller PhilMiller added this to the Release 3.7.02 milestone Jan 25, 2023
@masterleinad masterleinad mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@cz4rs cz4rs cz4rs approved these changes

@crtrott crtrott Awaiting requested review from crtrott

@dalg24 dalg24 Awaiting requested review from dalg24

@nmm0 nmm0 Awaiting requested review from nmm0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.7.02
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ndellingwood @masterleinad @cz4rs @PhilMiller @dalg24 @nmm0