Fix max scratch size calculation for level 0 of CUDA and HIP #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilMiller
reviewed
Dec 21, 2022
|
This maybe leaves the question of whether we should provide a version that takes the functor for the case where it matters, and make sure the documentation points users to that. |
This will still not give the actual available scratch if the functor were to do certain types of reductions, in which case some static shared memory is used which depends on the value_type size, and thus can't be accounted for without knowing the functor.
crtrott
force-pushed
the
fix-cuda-max-scratch-size-calc
branch
from
a4d28d4
to
6d88ba8
Compare
PhilMiller
reviewed
Dec 21, 2022
PhilMiller
reviewed
Dec 21, 2022
PhilMiller
reviewed
Dec 21, 2022
This will still not give the actual available scratch if the functor were to do certain types of reductions, in which case some static shared memory is used which depends on the value_type size, and thus can't be accounted for without knowing the functor.
crtrott
force-pushed
the
fix-cuda-max-scratch-size-calc
branch
from
6d88ba8
to
752c6db
Compare
|
(Your HIP commit message got truncated) |
dalg24
requested changes
Dec 21, 2022
PhilMiller
reviewed
Dec 21, 2022
PhilMiller
reviewed
Dec 21, 2022
|
This may also address #3498 |
PhilMiller
approved these changes
Dec 22, 2022
dalg24
reviewed
Dec 22, 2022
dalg24
reviewed
Dec 22, 2022
Rombur
approved these changes
Dec 22, 2022
dalg24
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes a bit better into account the internal shared memory teams are using by default. It does not take into account static shared memory which teams may use for certain types of team level reductions. The amount of shared memory there depends on the
value_typeand thus can't be taken into account without handing over the functor.It does otherwise fix #1811