Added multiple reducers support for team-level parallel reduce #5727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please. |
1 similar comment
|
Retest this please. |
ldh4
force-pushed
the
reduce_multiple_reducers
branch
from
0d99fef
to
742ea19
Compare
dalg24
reviewed
Feb 15, 2023
tcclevenger
reviewed
Feb 16, 2023
ldh4
force-pushed
the
reduce_multiple_reducers
branch
from
66b0a3a
to
ba8427a
Compare
TeamThreadRange, ThreadVectorRange, TeamVectorRange
…Target tests list
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
ldh4
force-pushed
the
reduce_multiple_reducers
branch
from
ba8427a
to
af212c0
Compare
Rombur
approved these changes
May 1, 2023
dalg24
requested changes
May 2, 2023
| EXPECT_EQ(n, hostView(0)); | ||
| EXPECT_EQ((n * (n + 1) / 2), hostView(1)); | ||
| EXPECT_EQ(n * n * (n + 1) / 2, hostView(2)); | ||
| EXPECT_EQ(n * n, hostView(3)); |
There was a problem hiding this comment.
Why 4 combined reduction rather than 3 or 2?
There was a problem hiding this comment.
No particular reason. Just wanted to test something more than just 2 reducers.
dalg24
reviewed
May 3, 2023
dalg24
approved these changes
May 3, 2023
|
I plan on ignoring in the CUDA-11.6-NVCC build. Still waiting on at least one of the HIP build to pass before I merge. |
|
Retest this please. |
Closed
nliber
pushed a commit
to nliber/kokkos
that referenced
this pull request
Jun 22, 2023
…s#5727) * Added interfaces and unit-tests for combined reducers supports for TeamThreadRange, ThreadVectorRange, TeamVectorRange * fixed warnings from unit tests * Fixed errors from CI tests * Added n=0 test cases * fixed warnings from unit tests * Removed team combined reducers unit-test file from OpenACC and OpenMPTarget tests list * quick syntax fix * Adjusted unit test skip conditions for openmptarget and openacc * Put in a macro guard to check if KOKKOS_ENABLE_CUDA_LAMBDA is defined * Addressing comments from reviews * Update core/src/impl/Kokkos_Combined_Reducer.hpp Co-authored-by: Daniel Arndt <arndtd@ornl.gov> * Update core/unit_test/TestTeamCombinedReducers.hpp Co-authored-by: Damien L-G <dalg24+github@gmail.com> * Converted write_one_value_back_on_device to a static function * Clang-formatted * git rebasing * Removed unnecessary fences from parallel_reduce_impl * Adjusted unit tests based on feedbacks * Adjusted expect_eq values in the unit tests * Removed a few ternary conditions --------- Co-authored-by: Daniel Arndt <arndtd@ornl.gov> Co-authored-by: Damien L-G <dalg24+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4510
Added an interface to allow parallel_reduce with TeamThreadRange, ThreadVectorRange or TeamVectorRange policy to be called with more than one reducer.