[3.7.02] fix src/dst Properties in deep_copy(DynamicView,View) #5732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In deep_copy(DynamicView, View), fix the dst Properties (DP) and the src Properties (SP) that were swapped in the using statements defining dst_type and src_type. Add a reproducer unit test.
|
Can one of the admins verify this patch? |
tkordenbrock
changed the title
|
Any chance this change could make it into the 4.0 release? |
|
yeah lets see if it passes testing this time, and then we can cherry pick it also to the relase-candidate. |
crtrott
approved these changes
Jan 8, 2023
|
Test this please. |
masterleinad
approved these changes
Jan 9, 2023
|
Retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In deep_copy(DynamicView, View), fix the dst Properties (DP) and the src Properties (SP) that were swapped in the using statements defining dst_type and src_type.
Add a reproducer unit test.