Add parameter to force using GlobalMemory launch mechanism using HIP #5796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rombur
force-pushed
the
force_global_launch
branch
from
4271bd9
to
67850ed
Compare
dalg24
requested changes
Jan 23, 2023
Rombur
force-pushed
the
force_global_launch
branch
from
67850ed
to
a4f4ea7
Compare
Rombur
force-pushed
the
force_global_launch
branch
from
a4f4ea7
to
0f8b7ca
Compare
dalg24
reviewed
Jan 23, 2023
dalg24
approved these changes
Jan 23, 2023
crtrott
requested changes
Jan 23, 2023
PhilMiller
changed the title
|
done |
crtrott
approved these changes
Jan 24, 2023
|
@Rombur plz cherry-pick into RC 4.0 |
This was referenced Jan 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameter that users can use to force a kernel to be launched using
GlobalMemory. This is sometimes necessary due to compiler bugs in ROCm 5.3 and ROCm 5.4 see #5606 and #5690cc: @arghdos