Implement rot{l,r} function templates
#5907
Conversation
|
Retest this please |
1 similar comment
|
Retest this please |
| Func::eval_constexpr(val_[i].x, val_[i].s)) { | ||
| ++e; | ||
| KOKKOS_IMPL_DO_NOT_USE_PRINTF( | ||
| "value at %x rotated by %d which is %x was expected to be %x\n", |
There was a problem hiding this comment.
Does the statement above clearly convey the expected condition?
There was a problem hiding this comment.
It prints on failure what the arguments were value at <x> rotated by <s>, what the function returned is <returned>, and what the expected value was was expected to be <reference>.
What is missing?
There was a problem hiding this comment.
Nothing (in terms of expected vs. actual) is missing, but this formulation (or some variation thereof) is clearer: It prints on failure what the arguments were value at <x> rotated by <s>, what the function returned is <returned>, and what the expected value was was expected to be <reference>.
There was a problem hiding this comment.
I don't understand your suggestion. Can you post a diff?
There was a problem hiding this comment.
Yes, later this afternoon. Any suggestion I might have about this is not critical for merging, BTW. But I'll take a whack at it later today.
|
Ignoring |
Following up on #4577