Drop KOKKOS_ENABLE_*_ATOMICS and KOKKOS_ENABLE_CUDA_ASM* macros
#5940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cz4rs
approved these changes
Mar 2, 2023
Rombur
approved these changes
Mar 2, 2023
|
Ignoring |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to step 3 in #5789
KOKKOS_ENABLE_CUDA_ASM*macros were exclusively used in our legacy atomics that we removed in #5804. They are never mentioned in the documentation.KOKKOS_ENABLE_*_ATOMICSmacros were not defined any more and we had reports like #5920 becauseprint_configurationwould give the impressions all atomics are disabled. All these print statements are being removed too.