Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sycl.large_team_scratch_size #5981

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Fix sycl.large_team_scratch_size #5981

merged 1 commit into from
Mar 14, 2023

Conversation

masterleinad
Copy link
Contributor

Apparently, I forgot the SYCLTeamMember constructor in #4728.

@masterleinad masterleinad force-pushed the fix_sycl_large_team_scratch_size branch from 6a74e9a to bb8a96b Compare March 13, 2023 19:10
@masterleinad masterleinad marked this pull request as ready for review March 13, 2023 19:18
dalg24
dalg24 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got an overflow?
This was merged into 3.7.00
Cherry-pick in 4.0.02 I suppose but what 3.7.02?

@masterleinad
Copy link
Contributor Author

Cherry-pick in 4.0.02 I suppose but what 3.7.02?

I didn't see the unit test falling before requiring oneAPI 2023.0.0 and we also said we wouldn't backport fixes for experimental backends so I tend not to cherry-pick for 3.7.02.

@dalg24 dalg24 merged commit 260886d into kokkos:develop Mar 14, 2023
This was referenced Mar 15, 2023
Closed
Closed
Merged
@dalg24
Copy link
Member

dalg24 commented Mar 17, 2023

Please improve the description in the entry you added to the changelogs

@masterleinad
Copy link
Contributor Author

Please improve the description in the entry you added to the changelogs

Improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@Rombur Rombur Rombur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masterleinad @dalg24 @Rombur