Desul atomics: let relocatable device code mode be part of the configuration #5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration is not compatible with the relocatable device code mode
…E_DEVICE_CODE macro guards
…ndled version of the desul atomics
dalg24
force-pushed
the
desul_atomics_separable_compilation
branch
from
c302dd5
to
22b8c70
Compare
dalg24
commented
Apr 11, 2023
There was a problem hiding this comment.
This file was removed in desul/desul#98
|
What release changelog should this be on? 4.1? |
masterleinad
approved these changes
Apr 11, 2023
If we want to mention it then yes. |
cz4rs
approved these changes
Apr 11, 2023
|
Ignoring GCC-8.4.0 failure |
Closed
masterleinad
pushed a commit
to masterleinad/kokkos
that referenced
this pull request
Apr 24, 2023
…uration (kokkos#5991) * Desul atomics: Make compilation fail if SEPARABLE_COMPILATION configuration is not compatible with the relocatable device code mode * Desul atomics: Prefer #ifdef DESUL_ATOMICS_ENABLE_{CUDA,HIP}_SEPARABLE_DEVICE_CODE macro guards * Desul atomics: add DESUL_ATOMICS_ENABLE_{CUDA,HIP}_SEPARABLE_COMPILATION macros * Configure DESUL_ATOMICS_ENABLE_{CUDA,HIP}_SEPARABLE_COMPILATION in bundled version of the desul atomics * Merge latest version * Fixup Clang+CUDA defines __CLANG_RDC__ instead of __CUDACC_RDC__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch incompatible RDC mode at compile time for CUDA and HIP