Fix warning in some user code when using std::memcpy #6000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nliber
requested changes
Mar 20, 2023
| @@ -414,7 +414,7 @@ struct HIPParallelLaunchKernelInvoker<DriverType, LaunchBounds, | |||
|
|
|||
| // Copy functor (synchronously) to staging buffer in pinned host memory | |||
| unsigned long *staging = hip_instance->constantMemHostStaging; | |||
| std::memcpy(staging, &driver, sizeof(DriverType)); | |||
| std::memcpy((void *)staging, (void *)&driver, sizeof(DriverType)); | |||
There was a problem hiding this comment.
We should use C++ casts and be const correct (as the C-style cast on &driver isn't, although in this particular case it won't matter, as calling memcpy will put the const back on), as in
std::memcpy(static_cast<void*>(staging), static_cast<const void*>(&driver), sizeof(driver));
dalg24
approved these changes
Mar 24, 2023
nliber
approved these changes
Mar 24, 2023
|
clang-format accident :) |
|
Please cherry-pick into 4.0.01 patch release |
|
Is this a problem in 3.7? I don't think so or? @Rombur Please cherry-pick to 4.0.01 |
dalg24
added a commit
to dalg24/kokkos
that referenced
this pull request
Mar 29, 2023
Fix warning in some user code when using std::memcpy
|
It's not a problem in 3.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the warning seen by user in #5998