Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0.01] Fix simd incorrect size return in avx2 #6011

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[4.0.01] Fix simd incorrect size return in avx2 #6011

merged 1 commit into from
Mar 24, 2023

Conversation

ldh4
Copy link
Contributor

@ldh4 ldh4 commented Mar 24, 2023

Cherry-picked #6004.

@ldh4
simd: Fixed an incorrectly returning size for uint64_t in avx2 (kokko…
8400cbf 
…s#6004)

* Fixed a size error in simd uint64_t avx2

* Converted unit test to compile time checks

* Removed an unused variable
@dalg24
Copy link
Member

dalg24 commented Mar 24, 2023

Failures look unrelated but re-running anyway. Retest this please.

dalg24
dalg24 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go ahead and list it under "bug fixes" in the 4.0.1 changelog issue

@dalg24
Copy link
Member

dalg24 commented Mar 24, 2023

Ignoring timing based failure on NVHPC build

7: [ RUN      ] cuda.debug_serial_execution
7: Time For1: 0.000126 For2: 0.000124 ForSerial: 0.000252
7: /var/jenkins/workspace/Kokkos/core/unit_test/cuda/TestCuda_DebugSerialExecution.cpp:113: Failure
7: Value of: passed_par_for
7:   Actual: false
7: Expected: true

@dalg24 dalg24 merged commit dc876ea into kokkos:release-candidate-4.0.01 Mar 24, 2023
@fnrizzi fnrizzi mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldh4 @dalg24 @masterleinad