Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: update package compatibility mode when building within Trilinos #6012

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

aprokop
Copy link
Collaborator

@aprokop aprokop commented Mar 24, 2023

Missed in #5759.

This is needed when building applications against Kokkos installed as part of the Trilinos. For example, it does not allow building ALEGRA using both recent versions of both ArborX and Trilinos.

@aprokop
Copy link
Collaborator Author

aprokop commented Mar 24, 2023

This may need to be cherry-picked into Trilinos as soon as possible.

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to cherry-pick into 4.0.01 patch release along with a new entry in the changelog

@dalg24 dalg24 added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Patch Release CMake labels Mar 24, 2023
@dalg24
Copy link
Member

dalg24 commented Mar 27, 2023

Ignoring clearly unrelated CI failures

@dalg24 dalg24 merged commit 9b6a80f into kokkos:develop Mar 27, 2023
@aprokop aprokop deleted the fix_version branch March 27, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) CMake Patch Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants