Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6027: replace remaining instances of ALL_t with Kokkos::ALL_t #6028

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

nmm0
Copy link
Contributor

@nmm0 nmm0 commented Mar 30, 2023

Fixes #6027

See #5807 and #5818

Also, I did a grep:

git grep -n -v "Kokkos::ALL_t" | grep "ALL_t"

The only instances found are the actual struct ALL_t so I'm fairly sure this is the last of them.

core/src/impl/Kokkos_ViewMapping.hpp:290:struct ALL_t {
core/src/impl/Kokkos_ViewMapping.hpp:292:  constexpr const ALL_t& operator()() const { return *this; }
core/src/impl/Kokkos_ViewMapping.hpp:295:  constexpr bool operator==(const ALL_t&) const { return true; }
core/src/impl/Kokkos_ViewMapping.hpp:300:// TODO This alias declaration forces us to fully qualify ALL_t inside the
core/src/impl/Kokkos_ViewMapping.hpp:302:// fully-qualified name when we remove Kokkos::Impl::ALL_t.
core/src/impl/Kokkos_ViewMapping.hpp:468:  // ALL_t

Maybe this should also be for the patch release?

@nmm0 nmm0 added this to the Release 4.1 milestone Mar 30, 2023
@dalg24 dalg24 merged commit 9b06259 into kokkos:develop Apr 1, 2023
@nmm0 nmm0 mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants