Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pointless Kokkos{Algorithms,Containers}_config.h files #6108

Merged

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented May 5, 2023

They are never included, not copied over to the install directory. They also have no counterpart in the hand-rolled makefiles.

Following up on #6104

They are never included, not copied over to the install directory.
They also have no counterpart in the hand-rolled makefiles.
@dalg24 dalg24 added Refactor Tidying up: make code code, cleaner, simpler, understandable and robust CMake labels May 5, 2023
@dalg24
Copy link
Member Author

dalg24 commented May 8, 2023

Ignoring HIP builds timing out.

@dalg24 dalg24 merged commit cf82edc into kokkos:develop May 8, 2023
27 of 28 checks passed
@dalg24 dalg24 deleted the drop_algorithms_and_containers_config_files branch May 8, 2023 12:07
@masterleinad masterleinad mentioned this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Refactor Tidying up: make code code, cleaner, simpler, understandable and robust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants