Cuda: Remove unused attach_texture_object #6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rombur
approved these changes
May 12, 2023
dalg24
approved these changes
May 12, 2023
There was a problem hiding this comment.
Impl::SharedAllocationRecord<CudaSpace, void>::attach_texture_object[_offset] are public member functions but SharedAllocationRecord belongs to implementation details.
So these functions are not part of Kokkos API and we can change them at will. That said, thanks Bruno for double checking for usage.
tcclevenger
approved these changes
May 12, 2023
|
Ignoring HIP builds that timed out |
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attach_texture_objectisn't used anymore since #5623. Also, see https://github.com/kokkos/kokkos/pull/5989/files#r1191202517.Technically, some of the functions are
publicbut I don't think it's necessary to deprecate them first.